home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 329039697

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1272#issuecomment-329039697 https://api.github.com/repos/pydata/xarray/issues/1272 329039697 MDEyOklzc3VlQ29tbWVudDMyOTAzOTY5Nw== 4992424 2017-09-13T02:34:21Z 2017-09-13T02:34:21Z NONE

Try refreshing? Latest commit is 7a767d8 and has all these changes plus some more tweaks.

Daniel Rothenberg * Postdoctoral Research Associate Center for Global Change Science Massachusetts Institute of Technology A: 77 Massachusetts Ave | E18-402A Cambridge, MA 02139 T: (502) 648-7513; T: (617) 258-0407 E: darothen@mit.edu H: *www.danielrothenberg.com http://github.com/darothen [image: http://www.linkedin.com/in/rothenbergdaniel/] http://www.linkedin.com/in/rothenbergdaniel/ http://www.twitter.com/danrothenberg

On Tue, Sep 12, 2017 at 12:02 PM, Stephan Hoyer notifications@github.com wrote:

@shoyer commented on this pull request.

In xarray/core/resample.py https://github.com/pydata/xarray/pull/1272#discussion_r138390791:

  • f = interp1d(x, y, kind=kind, axis=axis, bounds_error=True,
  • assume_sorted=True)
  • Prepare coordinates by dropping non-dimension coordinates along the

  • resampling dimension.

  • note: the lower-level Variable API could be used to speed this up

  • coords = OrderedDict()
  • if self._obj.data_vars:
  • var = list(self._obj.data_vars.keys())[0]
  • da = self._obj[var].copy()

did you push those commits yet? I'm not seeing it yet

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1272#discussion_r138390791, or mute the thread https://github.com/notifications/unsubscribe-auth/AEwtqKtNFFYYlmBgLHyDLPVZNJe7T18Gks5shqqdgaJpZM4MDalB .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  208215185
Powered by Datasette · Queries took 0.561ms · About: xarray-datasette