home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 328969823

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1570#issuecomment-328969823 https://api.github.com/repos/pydata/xarray/issues/1570 328969823 MDEyOklzc3VlQ29tbWVudDMyODk2OTgyMw== 1217238 2017-09-12T20:08:51Z 2017-09-12T20:08:51Z MEMBER

One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray.

Well, this is probably a good reason to leave out any that we feel unsure about.

Then there's also the timeout parameter, for which I think we will need to import some module within pydap just to get DEFAULT_TIMEOUT. That seems a bit awkward?

Yes, that would make me hesitant to use it, especially if it's not clear that DEFAULT_TIMEOUT is a supported API.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  257076194
Powered by Datasette · Queries took 0.808ms · About: xarray-datasette