That works for me. But note that you can also use **kwargs to insert conditional keyword arguments. On Mon, Sep 11, 2017 at 10:01 PM Joe Hamman notifications@github.com wrote:

@jhamman commented on this pull request.

In xarray/core/ops.py https://github.com/pydata/xarray/pull/1568#discussion_r138251821:

• if axis < 0:
• axis = a.ndim + axis
• depth = {d: 0 for d in range(a.ndim)}
• depth[axis] = window - 1
• boundary = {d: np.nan for d in range(a.ndim)}

• create ghosted arrays

• ag = da.ghost.ghost(a, depth=depth, boundary=boundary)

• apply rolling func

• out = ag.map_blocks(moving_func, window, min_count=min_count,
• axis=axis, dtype=a.dtype)

• trim array

• result = da.ghost.trim_internal(out, depth)
• return result + + +def dask_rolling_wrapper_without_min_count(moving_func, a, window, axis=-1):

If we update the minimum support bottleneck version to 1.1, we can do away with this special case (also present for the non-dask case) all together.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1568#discussion_r138251821, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gpgrbD_70fLL77G1RJClRZQbXSUks5shhANgaJpZM4PUFEa .