issue_comments: 328438707

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-328438707 https://api.github.com/repos/pydata/xarray/issues/1473 328438707 MDEyOklzc3VlQ29tbWVudDMyODQzODcwNw== 1217238 2017-09-11T07:14:55Z 2017-09-11T07:14:55Z MEMBER

I thought we have agreed to simply neglect the coordinate conflict (comment).

To be honest, it's still not clear to me which is the right choice.

Some considerations:

  • Coordinates are likely to differ by only a small amount in some practical settings, e.g., when using method='nearest'. It will be annoying to need to ensure coordinate alignment in such cases. For example, ds.reindex_like(other, method='nearest') would no longer work.
  • Dropping coordinate coordinates is not too difficult, but is somewhat annoying, because it requires users to lookup a new method (e.g.,reset_index()). Even for me, I had to do a little bit of experimentation to pick the right method. reset_index() does not have a default of resetting all indexes, which makes this slightly more annoying still (this would not be hard to fix).
  • There are situations where silently ignoring a conflict could result in silently corrupted results. This seems most likely to me with boolean or integer (isel()) indexing, where the indexer could have entries in the wrong order. However, this is unlikely with label-based indexing (sel or reindex), because the labels are already (redundantly) specified in the indexer values.

One possible resolution is to require exactly matching dimension coordinates only for isel() but not sel. However, this could be tricky to implement (sel is written in terms of isel) and could also be surprising to users, who expect sel() and isel() to work exactly the same except for expecting coordinates vs integer positions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773