issue_comments: 328403754

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-328403754 https://api.github.com/repos/pydata/xarray/issues/1473 328403754 MDEyOklzc3VlQ29tbWVudDMyODQwMzc1NA== 6815844 2017-09-11T03:04:05Z 2017-09-11T03:04:05Z MEMBER

Thank you for review.

I thought we agreed that these cases should raise an error, i.e., to require exact alignment?

I thought we have agreed to simply neglect the coordinate conflict (comment).

Yes, but now I agree to raise an IndexError is clearer for users. I will revert it.

The interaction with MultiIndex indexing seems to be somewhat off. Compare:

I forgot to consider MultiIndex. I will fix it.

(May be later this week.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773