issue_comments: 327802435

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-327802435 https://api.github.com/repos/pydata/xarray/issues/1473 327802435 MDEyOklzc3VlQ29tbWVudDMyNzgwMjQzNQ== 6815844 2017-09-07T13:40:30Z 2017-09-07T13:40:30Z MEMBER

Added, with some code clean-ups.

(Although I prepared tests for it), I agree that the boolean indexing with a different dimension name is a rare use case

But I personally think this rule adds additional complexity. From an analogy of np.ndarray indexing python da.values[(da.y > -1).values] this looks like a just a mis-coding of python da.values[:, (da.y > -1).values] and this error may be user's responsibility.

I think we should recommend da.isel(y=(da.y>-1)) instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773