issue_comments: 327005863

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1551#issuecomment-327005863 https://api.github.com/repos/pydata/xarray/issues/1551 327005863 MDEyOklzc3VlQ29tbWVudDMyNzAwNTg2Mw== 1217238 2017-09-04T17:28:56Z 2017-09-04T17:28:56Z MEMBER

Yeah, that's OK, I just liked your TODO :)

On Mon, Sep 4, 2017 at 1:33 AM crusaderky notifications@github.com wrote:

@crusaderky commented on this pull request.

In xarray/core/combine.py https://github.com/pydata/xarray/pull/1551#discussion_r136769128:

@@ -208,6 +219,8 @@ def _dataset_concat(datasets, dim, data_vars, coords, compat, positions): dim, coord = _calc_concat_dim_coord(dim) datasets = [as_dataset(ds) for ds in datasets] datasets = align(*datasets, join='outer', copy=False, exclude=[dim]) + # TODO: compute dask coords with a single invocation of dask.compute()

I didn't bother as it would be a considerable complication and it would not do any good in the most common case where the "dask" variable is just a lazy load from disk

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1551#discussion_r136769128, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1kdcqAVVgdHoOZGKBf-IuFBdVJWbks5se7XugaJpZM4PLCZy . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   254841785