home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 326868217

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1521#issuecomment-326868217 https://api.github.com/repos/pydata/xarray/issues/1521 326868217 MDEyOklzc3VlQ29tbWVudDMyNjg2ODIxNw== 1217238 2017-09-04T05:18:55Z 2017-09-04T05:18:55Z MEMBER

So, to be more precise, I think the problem is that the first variable is computed many times over (once per comparison), inside the differs helper function above.

A very simple fix, slightly more conservative than loading every coordinate into memory, is to simply compute these first coordinates on the first variable, e.g., v = datasets[0].variables[vname] -> v = datasets[0].variables[vname].compute(). I am slightly nervous about the potential memory overhead of loading all coordinates into memory.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  252541496
Powered by Datasette · Queries took 0.703ms · About: xarray-datasette