issue_comments: 326367356
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/1473#issuecomment-326367356 | https://api.github.com/repos/pydata/xarray/issues/1473 | 326367356 | MDEyOklzc3VlQ29tbWVudDMyNjM2NzM1Ng== | 1217238 | 2017-08-31T17:32:02Z | 2017-08-31T17:32:02Z | MEMBER | I agree that this is pretty close! I will do another review shortly when I have time. This is a really exciting feature and I am super excited to get it into v0.10 -- thanks again for your hard work on it! This goes a long way to completing xarray's labeled data model. The consensus over in #1535 seems to be that we can go ahead without a deprecation warning. Also: I agree that it would be great if others can test this, but we should also definitely make a release candidate for 0.10 to help iron out any bugs before the final release. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
241578773 |