issue_comments: 326334294

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-326334294 https://api.github.com/repos/pydata/xarray/issues/1473 326334294 MDEyOklzc3VlQ29tbWVudDMyNjMzNDI5NA== 6815844 2017-08-31T15:36:49Z 2017-08-31T15:39:24Z MEMBER
  • [x] Closes #1444, #1436
  • [x] Tests added / passed
  • [x] Passes git diff master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I think I am approaching.

See docs for the detail, but the essential change of this PR is that now indexing ([], .loc[], .sel(), .isel()) considers indexers dimension. By passing xr.DataArray as indexers, we can realize many types of advanced indexing, which is done previously by special methods isel_points, sel_points, and reindex. (isel_points and sel_points are deprecated by this PR.)

If indexers have no named dimension (e.g. np.ndarray, integer, slice), then the indexing behaves exactly the same way to the current version. So this change should be compatible almost all the existing codes.

Now all the existing tests passed and I added many test cases as far as I think of. However, I would like to ask members to use this branch for your daily work and make sure there is no inconvenience, because indexing is very fundamental and a single bug would affect every user significantly.

Any comments or thoughts are welcome.

(I refactored indexing.rst largely according to this change. I would also appreciate very much if anyone could point out some confusing/unnatural sentences.)

I am looking forward to seeing it in v.0.10 :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773