home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 324966586

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1514#issuecomment-324966586 https://api.github.com/repos/pydata/xarray/issues/1514 324966586 MDEyOklzc3VlQ29tbWVudDMyNDk2NjU4Ng== 5700886 2017-08-25T16:12:23Z 2017-08-25T16:12:23Z CONTRIBUTOR

One more thing:

Can we add pathlib2 as an optional dependency and handle the case where it's not installed?

Currently, I've set pathlib2 as a mandatory requirement for Python 2. How'd we achieve pathlib being optional? Test for pathlib upon import and wrap all the if isinstace(path, Path): path = str(path) in a function just passing unmodified path if pathlib's not present?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  251734482
Powered by Datasette · Queries took 0.642ms · About: xarray-datasette