home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 324962241

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1514#issuecomment-324962241 https://api.github.com/repos/pydata/xarray/issues/1514 324962241 MDEyOklzc3VlQ29tbWVudDMyNDk2MjI0MQ== 5700886 2017-08-25T15:56:20Z 2017-08-25T15:56:20Z CONTRIBUTOR
  • [x] Tests added / passed

Tests are already done on my personal Travis Account (skipped intermediate commits there).

  • [x] Passes git diff upstream/master | flake8 --diff

Actually true only for git diff upstream/master xarray/ | flake8 --diff. But I guess that's what should pass the linter?

To me, aae32a8 looks like pathlib support is now present whereever it makes sense.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  251734482
Powered by Datasette · Queries took 160.623ms · About: xarray-datasette