issue_comments: 321148108

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-321148108 https://api.github.com/repos/pydata/xarray/issues/1473 321148108 MDEyOklzc3VlQ29tbWVudDMyMTE0ODEwOA== 1217238 2017-08-09T04:16:03Z 2017-08-09T04:16:03Z MEMBER

@fujiisoup you're asking good questions about how to handle coordinates.

I don't have a lot of time to think about this right now, but really briefly: - Overwrite da['x'] by ind['x'] seems bad. This seems contrary to how indexing is supposed to work. I don't think we ever want to override/change coordinates in the indexed object. - My inclination would be that it's OK to add coordinates from the indices as long as they aren't conflicting (with either other indices or the indexed objected). This will cause some increase in the number of coordinates but I don't think this would be too bad.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773