issue_comments: 318813583

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-318813583 https://api.github.com/repos/pydata/xarray/issues/1473 318813583 MDEyOklzc3VlQ29tbWVudDMxODgxMzU4Mw== 6815844 2017-07-29T08:26:30Z 2017-07-29T08:26:30Z MEMBER

@shoyer

Thanks for the detailed review.

I don't think we want to index non-xarray types with IndexerTuple subclasses. It's probably best to any convert them into base tuple() objects before indexing.

Yes. Actually, some backends seem to check something like if type(key) is tuple if key is empty. So, in my previous implementation, I manually converted its instance type in case of an empty tuple. I added to_tuple() method to IndexerTuple class and called it in all the basic ArrayWrapper. I think this made the code a bit cleaner.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773