issue_comments: 317795244

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-317795244 https://api.github.com/repos/pydata/xarray/issues/1473 317795244 MDEyOklzc3VlQ29tbWVudDMxNzc5NTI0NA== 1217238 2017-07-25T16:35:09Z 2017-07-25T16:35:09Z MEMBER

As you suggested, I prepared our own indexer class. I think the codes became much cleaner.

Thanks! I'll take a look shortly.

Maybe this behavior was deprecated in numpy?

Yes, I think NumPy has deprecated/removed this sort of indexing.

In my current PR, the boolean index is simply converted to integer array by .nonzero() method, so xarray works with such boolean array with different size. Is it what we want?

No, for 1D boolean arrays I think we should insist that sizes match exactly. There is no obvious map between boolean indexer positions and array values otherwise.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773