issue_comments: 317742791

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-317742791 https://api.github.com/repos/pydata/xarray/issues/1473 317742791 MDEyOklzc3VlQ29tbWVudDMxNzc0Mjc5MQ== 6815844 2017-07-25T13:48:12Z 2017-07-25T13:48:12Z MEMBER

@shoyer Thanks for the suggestion. As you suggested, I prepared our own indexer class. I think the codes became much cleaner.

I struggled with the boolean index behavior, python np.random.randn(10, 20)[np.arange(8) < 5] which works in my laptop but fails in travis. Maybe this behavior was deprecated in numpy?

In my current PR, the boolean index is simply converted to integer array by .nonzero() method, so xarray works with such boolean array with different size. Is it what we want?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773