issue_comments: 316404161

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1272#issuecomment-316404161 https://api.github.com/repos/pydata/xarray/issues/1272 316404161 MDEyOklzc3VlQ29tbWVudDMxNjQwNDE2MQ== 4992424 2017-07-19T14:24:38Z 2017-08-04T16:39:53Z NONE

TODO

  • [x] ensure that count() works on Data{Array,set}Resample objects
  • [x] refactor Data{Array,set}Resample objects into a stand-alone file core/resample.py alongside core/groupby.py
  • [x] wrap pytest.warns around tests targeting old API
  • [x] move old API tests into stand-alone
  • [x] Crude up-sampling. Copy/pasting Stephan's earlier comment from Feb 20:

I think we need to fix this before merging this PR, since it suggests the existing functionality would only exist in deprecated form. Pandas does this with a method called .asfreq, though this is basically pure sugar since in practice I think it works exactly the same as .first (or .mean if only doing pure upsampling).

Alright @jhamman, here's the complete list of work left here. I'll tackle some of it during my commutes this week.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   208215185