issue_comments: 315746067

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-315746067 https://api.github.com/repos/pydata/xarray/issues/1473 315746067 MDEyOklzc3VlQ29tbWVudDMxNTc0NjA2Nw== 6815844 2017-07-17T12:49:46Z 2017-07-17T12:50:55Z MEMBER

@shoyer Thanks for your help.

Let's not worry about supporting every indexing type with dask.

Yes. Thanks to your patch, dask-based variable is now indexed fine.

Some replies to your comments to the outdated codes. + multidimensional boolean indexer
Agree. I added a sanity check and raise IndexError in case of multi-dimensional boolean array. + indexer type in DasokIndexingAdapter
Because I changed how indexing.broadcasted_indexable (formally indexing.orthogonally_indexable) is called, indexers passed to DaskIndexingAdapter are already broadcasted to Variables (in case of _broadcast_indexes_advanced).

I will try to fit the other array wrappers, LazilyIndexedArray, CopyOnWriteArray, MemoryCachedArray to the broadcasted indexers, the tests of which currently fail. (Maybe I will need another help.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773