issue_comments: 315637844
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/1414#issuecomment-315637844 | https://api.github.com/repos/pydata/xarray/issues/1414 | 315637844 | MDEyOklzc3VlQ29tbWVudDMxNTYzNzg0NA== | 102827 | 2017-07-16T21:15:04Z | 2017-07-16T21:34:12Z | CONTRIBUTOR | @jhamman - I found some differences between the old code in master an my code when decoding values close to the np.datetime64 overflow. My code produces First, I wanted to test and fix that. However, I may have found that the old implementation did not behave correctly when crossing the "overflow" line just slightly. I have summed that up in a notebook here. My conclusion would be, that the code in this PR here is not only faster, but also more correct than the old one. However, since it is quite late in the evening and my head needs some rest, I would like to get a second (or third) opinion... |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
229807027 |