issue_comments: 315178012

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1131#issuecomment-315178012 https://api.github.com/repos/pydata/xarray/issues/1131 315178012 MDEyOklzc3VlQ29tbWVudDMxNTE3ODAxMg== 2443309 2017-07-13T19:27:25Z 2017-07-13T19:27:25Z MEMBER

In reviewing this PR, I'm not really a fan of special casing the 1-D array in the way described above. These sorts of decisions lead to unexpected/confusing behavior when scaling up analysis. Obviously there is a tradeoff here as we diverge from how the numpy.diff function works but I think that is something we'd prefer to live with. I think this falls under the explicit is better than implicit idea...

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   190026722