issue_comments: 313061867

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1469#issuecomment-313061867 https://api.github.com/repos/pydata/xarray/issues/1469 313061867 MDEyOklzc3VlQ29tbWVudDMxMzA2MTg2Nw== 6815844 2017-07-05T10:13:18Z 2017-07-05T10:13:18Z MEMBER

@shoyer Sorry. My example was still not good (I modified the previous example slightly).

I think my current implementation does not work even for (the future version of) .sel, because the resultant xr.Dataset has the index for 'y' and labels for 'x'.

As you suggested, it looks more xarray-like if it returns coordinates for both 'x' and 'y', python <xarray.Dataset> Dimensions: (x: 3) Coordinates: * x (x) <U1 'c' 'b' 'a' Data variables: y (x) float64 1.4 4.3 1.4 so that it can be passed to .sel.

This API looks much more natural to me than the current one, although it has to wait for #974. I will update this PR.

For the function name. Based on your suggestion, how about labels_min or argmin_labels? I think function names of idxmin and (the current) indexes_min can be too different because idxmin should return 'index' while indexes_min returns label.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   239918314