issue_comments: 312908355

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1469#issuecomment-312908355 https://api.github.com/repos/pydata/xarray/issues/1469 312908355 MDEyOklzc3VlQ29tbWVudDMxMjkwODM1NQ== 6815844 2017-07-04T15:46:20Z 2017-07-05T10:06:53Z MEMBER

@shoyer Thanks for the comments.

  • APIs
    Sounds reasonable suggestions. I renamed argmin_indexs -> indexes_min. Also I added idxmin that works as similar to pandas's idxmin. The APIs are
    python def indexes_min(self, dims=None, skipna=True): and python def idxmin(self, dim=None, skipna=True, keep_dims=False): (I found keep_dims for indexes_min brings another confusion and omit from them).

  • isel_points's issue Currently, indexes_min works as ```python In [1]: import xarray as xr ...: da = xr.DataArray([[1, 2], [51, 40], [5, 6]], ...: [('x', ['c', 'b', 'a']), ('y', [1.4, 4.3])]) ...: da ...: Out[1]: <xarray.DataArray (x: 3, y: 2)> array([[ 1, 2], [51, 40], [ 5, 6]]) Coordinates:

  • x (x) <U1 'c' 'b' 'a'
  • y (y) float64 1.4 4.3

In [2]: da.indexes_min(dims='y') Out[2]: <xarray.Dataset> Dimensions: (x: 3) Coordinates: * x (x) <U1 'c' 'b' 'a' Data variables: y (x) float64 0 1 0

```

However, arguments of isel_points should be like python <xarray.Dataset> Dimensions: (points: 3) Data variables: x (points) int64 0 1 2 y (points) int64 0 1 0

This behavior is more intuitive?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   239918314