issue_comments: 312745886

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1469#issuecomment-312745886 https://api.github.com/repos/pydata/xarray/issues/1469 312745886 MDEyOklzc3VlQ29tbWVudDMxMjc0NTg4Ng== 1217238 2017-07-03T22:49:39Z 2017-07-03T22:49:39Z MEMBER

A few quick thoughts on API design:

  • The most similar pandas method is called idxmin. We may not want to use the exact same name here, but it's something to keep in mind.
  • We might want two separate methods, one like this that returns an OrderedDict/Dataset and another that returns just one DataArray (for use when reducing over only one axis). I might pick idxmin and indexes_min.
  • A keep_dims=True argument like numpy is a nice way to preserve dimensions if desired.
  • I'm a little surprised that it doesn't work to unpack a Dataset with ** in isel_points -- in theory I think it should.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   239918314