issue_comments: 309280411

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1388#issuecomment-309280411 https://api.github.com/repos/pydata/xarray/issues/1388 309280411 MDEyOklzc3VlQ29tbWVudDMwOTI4MDQxMQ== 6815844 2017-06-18T14:18:40Z 2017-06-19T12:56:03Z MEMBER

I'm working to fix this and I would like to make some design decisions;

  1. What should max() look like? I guess this method should work also for multi-dimensional data. To satisfy the arr.isel_points(**arr.argmin_indices(dim)) == arg.min(dim) relation, the result array should have proper coordinates?

  2. Multiple dim arguments Currently, doc says argmin accepts multiple axes, but np.argmin does not. Can we limit argmin's arguments only str not sequence of strs?

Edit:

  1. Multi-dimensional array to isel_points Currently, isel_points only accepts 1-dimensional array, while the result of argmin_indexes can be multi-dimensional, e.g. python xr.DataArray(np.random.randn(4, 3, 2), dims=['x', 'y', 'z']).argmin_indexes(dims=['x']) Do we need special treatment for this (maybe in isel_points) or just raise an Error (current behavior)?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   224878728