home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 305034234

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1434#issuecomment-305034234 https://api.github.com/repos/pydata/xarray/issues/1434 305034234 MDEyOklzc3VlQ29tbWVudDMwNTAzNDIzNA== 1217238 2017-05-30T23:08:48Z 2017-05-30T23:08:48Z MEMBER

Thanks for the report, I'm marking this as a bug.

The issue is with these lines in IndexVariable.concat. We defer to pandas for concatenating coordinate labels, but pandas doesn't handle structured dtypes properly (it converts them to dtype=object). This is part of why we have PandasIndexAdapter.

It seems like we now need some more complex logic for toggling between pandas Index.append() and numpy.concatenate, based on the Index dtypes.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  232350436
Powered by Datasette · Queries took 0.823ms · About: xarray-datasette