issue_comments: 304924644

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1429#issuecomment-304924644 https://api.github.com/repos/pydata/xarray/issues/1429 304924644 MDEyOklzc3VlQ29tbWVudDMwNDkyNDY0NA== 1217238 2017-05-30T15:57:19Z 2017-05-30T15:57:19Z MEMBER

I thought this would be fixed https://github.com/pydata/xarray/pull/1433, but this is actually a different issue.

We need to wrap the indexing result here for orthogonal indexing, but that probably shouldn't happen in the MemoryCachedArray layer. For SciPy, this happens inside ScipyArrayWrapper.__getitem__. For NumPy, this currently happens inside indexing.orthogonally_indexable.

Right now, xarray assumes that unknown array type that makes it into Variable._data supports orthogonal indexing. This is probably a mistake: we really should be more explicit and make fewer assumptions, perhaps by explicitly listing allowed array types or adding a registration system.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   231811609