home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 304481844

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1260#issuecomment-304481844 https://api.github.com/repos/pydata/xarray/issues/1260 304481844 MDEyOklzc3VlQ29tbWVudDMwNDQ4MTg0NA== 1217238 2017-05-27T23:23:02Z 2017-05-27T23:23:02Z MEMBER

I think DataArray.chunk should probably gain those parameters. There just wasn't any need for it before. On Sat, May 27, 2017 at 9:35 AM Fabien Maussion notifications@github.com wrote:

@fmaussion commented on this pull request.

In xarray/backends/rasterio_.py https://github.com/pydata/xarray/pull/1260#discussion_r118824181:

  • y = np.linspace(start=y0, num=ny, stop=(y0 + (ny - 1) * dy)) +
  • Get bands

  • if riods.count < 1:
  • raise ValueError('Unknown dims')
  • bands = np.asarray(riods.indexes) +
  • Attributes

  • attrs = {}
  • if hasattr(riods, 'crs'):
  • CRS is a dict-like object specific to rasterio

  • We convert it back to a PROJ4 string using rasterio itself

  • attrs['crs'] = riods.crs.to_string()
  • Maybe we'd like to parse other attributes here (for later)

    +
  • data = indexing.LazilyIndexedArray(RasterioArrayWrapper(riods))

Implementing cache went well (appart from this bug https://github.com/pydata/xarray/issues/1429.

For chunking I have a question: DataArray.chunk() doesn't have http://xarray.pydata.org/en/stable/generated/xarray.DataArray.chunk.html#xarray.DataArray.chunk the name_prefix, token and lock keywords. Any reason for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1260#discussion_r118824181, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1mo_XZFgCNEq4YoJunYeeWve5XHPks5r-FDDgaJpZM4L92Pl .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  206905158
Powered by Datasette · Queries took 0.888ms · About: xarray-datasette