home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 303794677

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/728#issuecomment-303794677 https://api.github.com/repos/pydata/xarray/issues/728 303794677 MDEyOklzc3VlQ29tbWVudDMwMzc5NDY3Nw== 1217238 2017-05-24T17:28:21Z 2017-05-24T17:28:21Z MEMBER

Is there a reason inheritance with a different init signature can't be allowed?

No strong reason -- we just didn't really consider (or test) inheritance in the current design. Certainly proposals (and PRs) for a subclassing API would be welcome.

At the very least, a big fat warning in the documentation would be helpful.

http://xarray.pydata.org/en/stable/internals.html#extending-xarray has some related guidance (I agree it could be louder)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  128980804
Powered by Datasette · Queries took 0.885ms · About: xarray-datasette