home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 303513756

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1422#issuecomment-303513756 https://api.github.com/repos/pydata/xarray/issues/1422 303513756 MDEyOklzc3VlQ29tbWVudDMwMzUxMzc1Ng== 1217238 2017-05-23T19:56:21Z 2017-05-23T19:56:21Z MEMBER

Mmm I don't see any current use of the copy keyword argument inside the as_variable function. Here is the only place where I found copy to be explicitly provided. Can I safely remove it also there?

Yes, we can safely remove the copy argument here. At point point, as_variable did not always return a new Variable object, but as you can see it always does that now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  230631480
Powered by Datasette · Queries took 0.673ms · About: xarray-datasette