home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 303378994

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1422#issuecomment-303378994 https://api.github.com/repos/pydata/xarray/issues/1422 303378994 MDEyOklzc3VlQ29tbWVudDMwMzM3ODk5NA== 4160723 2017-05-23T12:13:56Z 2017-05-23T12:13:56Z MEMBER

Oh yes I haven't run the tests locally before submitting this, I didn't expected that.

Mmm I don't see any current use of the copy keyword argument inside the as_variable function. Here is the only place where I found copy to be explicitly provided. Can I safely remove it also there? If I remove it the tests pass again (although I got 3 remaining failing tests that don't seem to be related to this issue as they fail either with or without the copy argument).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  230631480
Powered by Datasette · Queries took 0.53ms · About: xarray-datasette