home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 302943727

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1414#issuecomment-302943727 https://api.github.com/repos/pydata/xarray/issues/1414 302943727 MDEyOklzc3VlQ29tbWVudDMwMjk0MzcyNw== 102827 2017-05-21T15:28:15Z 2017-05-21T15:28:15Z CONTRIBUTOR

Thanks @shoyer and @jhamman for the feedback. I will change things accordingly.

Concerning tests, I will think again about additional checking for correct handling of overflow. I must admit, that I am not 100% sure that every case is handled correctly by the current code and checked by the current tests. Will have to think about it a little when I find time within the next days...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  229807027
Powered by Datasette · Queries took 0.815ms · About: xarray-datasette