issue_comments: 302511481

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1413#issuecomment-302511481 https://api.github.com/repos/pydata/xarray/issues/1413 302511481 MDEyOklzc3VlQ29tbWVudDMwMjUxMTQ4MQ== 1217238 2017-05-18T19:04:18Z 2017-05-18T19:04:18Z MEMBER

This enhancement makes a lot of sense to me.

Two things worth considering:

  1. Given a collection of datasets, how do I know if setting prealigned=True will work? This is where my PR adding xr.align(..., join='exact') could help (I can finish that up). Maybe it's worth adding xr.is_aligned or something similar.
  2. What happens if things go wrong? It's okay if the behavior is undefined (or could give wrong results) but we should document that. Ideally we should raise sensible errors at some later time, e.g., when the dask arrays are computed. This might or might not be possible to do efficiently with dask, if the result of all the equality checks are consolidated and added into the dask graphs of the results.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   229474101