issue_comments: 302299557

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1412#issuecomment-302299557 https://api.github.com/repos/pydata/xarray/issues/1412 302299557 MDEyOklzc3VlQ29tbWVudDMwMjI5OTU1Nw== 6815844 2017-05-18T04:48:29Z 2017-05-18T04:48:29Z MEMBER

@shoyer Thanks for the comment.

It breaks an important invariant, which is that indexing a Variable returns another Variable.

I totally agree with you.

In the last commit, I moved the unpacking functionality into Dataset, and restored the modification in Variable class I made. I think the current is cleaner than my previous one, but I'm not yet comfortable with it. There are a lot of functions or if-statements related to MultiIndex in different places. I guess they should be bundled in one place.

Adding functions is easy but simplifying them are difficult...

If anyone show a direction, I will try the improvement.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   229370997