issue_comments: 300838234
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/939#issuecomment-300838234 | https://api.github.com/repos/pydata/xarray/issues/939 | 300838234 | MDEyOklzc3VlQ29tbWVudDMwMDgzODIzNA== | 221526 | 2017-05-11T16:08:19Z | 2017-05-11T16:08:19Z | CONTRIBUTOR | I agree that having too many keyword arguments is poor design; it's representative of either failing to abstract anything away or having the object/function just do too much. For a specific example, this jumps out to me as a problem:
I'd be in favor of having lightweight classes (essentially mutable named tuples) vs. dictionaries. The former allows more discoverability to the interface (i.e. tab completion in IPython) as well as better up-front error checking (you could use |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
169274464 |