home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 300647473

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/939#issuecomment-300647473 https://api.github.com/repos/pydata/xarray/issues/939 300647473 MDEyOklzc3VlQ29tbWVudDMwMDY0NzQ3Mw== 12307589 2017-05-11T00:16:34Z 2017-05-11T00:16:34Z CONTRIBUTOR

It is considered poor software design to have 13 arguments in Java and other languages which do not have optional arguments. The same isn't necessarily true of Python, but I haven't seen much discussion or writing on this.

I'd much rather have pandas.read_csv the way it is right now than to have a ReadOptions object that would need to contain exactly the same documentation and be just as hard to understand as read_csv. That object would serve only to separate the documentation of the settings for read_csv from the docstring for read_csv. If you really want to cut down on arguments, open_dataset should be separated into multiple functions. I wouldn't necessarily encourage these, but some possibilities are:

  • Have a function which takes in an undecoded dataset and returns a CF-decoded dataset, instead of a decode_cf kwarg
  • Have a function which takes in an unmasked/unscaled dataset and returns a masked/scaled dataset, instead of mask_and_scale
  • Have a function which takes in a dataset with undecoded times and returns a decoded dataset, instead of decode_times
  • similarly for decode_coords, chunks, and drop_variables. Should chunks and drop_variables even exist as kwargs, given that the functions to do these to a dataset already exist?

All of that aside, the DecoderOptions object already exists if that's what you want - it's the dict.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  169274464
Powered by Datasette · Queries took 0.732ms · About: xarray-datasette