issue_comments: 298755199

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1393#issuecomment-298755199 https://api.github.com/repos/pydata/xarray/issues/1393 298755199 MDEyOklzc3VlQ29tbWVudDI5ODc1NTE5OQ== 1392657 2017-05-02T20:43:18Z 2017-05-02T20:43:18Z CONTRIBUTOR

Ok, sounds good. shutil was no longer needed, but the md5 checksum was implemented as private. So I think all is well.

On Tue, May 2, 2017 at 2:32 PM, Stephan Hoyer notifications@github.com wrote:

Thanks for taking this on @gidden https://github.com/gidden.

Also not sure how best to import shutil. I followed the current pattern for os, but am not sure why that pattern exists in this file.

I think this exists to work around the fact that IPython shows everything that isn't private in auto-complete (ipython/ipykernel#129 https://github.com/ipython/ipykernel/issues/129). But we should probably switch back to normal imports in this module -- this is really more of an IPython issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1393#issuecomment-298737305, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVAEW5GuD6D_Y4ANjqM5AnK54h5BRZtks5r14TCgaJpZM4NOCuy . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   225672435