issue_comments: 298705664

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1393#issuecomment-298705664 https://api.github.com/repos/pydata/xarray/issues/1393 298705664 MDEyOklzc3VlQ29tbWVudDI5ODcwNTY2NA== 1392657 2017-05-02T17:34:06Z 2017-05-02T17:34:06Z CONTRIBUTOR

It seems like urlretrieve is coming directly from urllib. It seems in both Python 2 and 3 ContentTooShort error should be thrown and isnt. Perhaps checksums are the right way to go.

On Tue, May 2, 2017 at 7:14 PM, Fabien Maussion notifications@github.com wrote:

@fmaussion commented on this pull request.

In xarray/tutorial.py https://github.com/pydata/xarray/pull/1393#discussion_r114372912:

     url = '/'.join((github_url, 'raw', 'master', fullname))
  • _urlretrieve(url, localfile)
  • _urlretrieve(url, tmpfile) +
  • if not _os.path.exists(tmpfile):
  • raise ValueError('File could not be downloaded, please try again') +
  • _shutil.move(tmpfile, localfile)

I thought that the issue wasn't that the file isn't downloaded, but rather that it is incompletely downloaded? Will this new temporary step than solve this?

Is there a way to make urlretrieve more robust, with checksums or something?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1393#pullrequestreview-35833283, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVAEVQ4rFwcddY-kEOYnaEaLHsxf_u9ks5r12RkgaJpZM4NOCuy . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   225672435