issue_comments: 297871870

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/967#issuecomment-297871870 https://api.github.com/repos/pydata/xarray/issues/967 297871870 MDEyOklzc3VlQ29tbWVudDI5Nzg3MTg3MA== 1217238 2017-04-28T00:03:57Z 2017-04-28T00:03:57Z MEMBER

@chunweiyuan I would skip inplace -- it's just not worth the complexity. It certainly does not make things any faster, so there is little gain from it. If you really want it, search for inplace in dataset.py and dataarray.py for examples.

When you assign to self, it creates a local variable: it doesn't override the object instance (Python doesn't support that).

I actually like the name sortby(), allowing any 1D variables as the argument (not just coordinates), as long as they have distinct dimensions. This works better for xarray than it does for pandas because we always have axis/dimension names.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   171077425