issue_comments: 291812719

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1347#issuecomment-291812719 https://api.github.com/repos/pydata/xarray/issues/1347 291812719 MDEyOklzc3VlQ29tbWVudDI5MTgxMjcxOQ== 6815844 2017-04-05T09:54:59Z 2017-04-05T09:54:59Z MEMBER

Thanks for the careful review.

  • Now it raises IndexError if any axis is out of bounds. ValueError is OK for the other part?
  • Removed unnecessary print line.
  • Removed the unzip -> rezip sequences.
  • Divide test_dataarray.test_expand_dims into small 2 tests.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   218745734