home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 289511480

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1326#issuecomment-289511480 https://api.github.com/repos/pydata/xarray/issues/1326 289511480 MDEyOklzc3VlQ29tbWVudDI4OTUxMTQ4MA== 6815844 2017-03-27T16:42:24Z 2017-03-27T16:42:24Z MEMBER

I would switch the order of the method arguments.

I agree this. Do you think it is confusing if this method automatically detects the positional argument, i.e. if string is passed then it should be the axis name and an integer should be axis position.

I think that numpy-like API is most user-friendly, as like TensorFlow imitates them. I like to support da.expand_dims(0) if it is not confusing for users who don't care the axes order.

We might also consider supporting inserting multiple axes at once

I guess that the reason that numpy doesn't support multiple axes insertion is it brings additional ambugousity to the new axes positions; e.g. da.expand_dims([2,1]) could behave python da.expand_dims(2) da.expand_dims(1) or python da.expand_dims(1) da.expand_dims(2) the results differ. (It does not matter if user only specifies the labels or the list is in order.)

I hesitate this option actually.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  216799807
Powered by Datasette · Queries took 0.782ms · About: xarray-datasette