issue_comments: 289484312

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1322#issuecomment-289484312 https://api.github.com/repos/pydata/xarray/issues/1322 289484312 MDEyOklzc3VlQ29tbWVudDI4OTQ4NDMxMg== 1217238 2017-03-27T15:12:15Z 2017-03-27T15:12:15Z MEMBER

If the logic is "clever", time to ditch it. I've rebased to a clearer version which simply handles indentation and replaces tabs and newlines with their backslash representations.

"Clever" was possibly too strong of a word. I think both your original and new proposal are fine -- use your own best taste on which version is most readable.

It's more that we need unit tests for any functionality. Otherwise, things tend to brake inadvertently when someone else does code cleanup months or years later.

What properties of this would you want to test?

This could be super simple here, e.g., just a few assert statements verifying the text substitutions and truncation. Ideally we exercise every line of logic in your code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   216611104