home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 286665079

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1289#issuecomment-286665079 https://api.github.com/repos/pydata/xarray/issues/1289 286665079 MDEyOklzc3VlQ29tbWVudDI4NjY2NTA3OQ== 2443309 2017-03-15T07:45:51Z 2017-03-15T07:45:51Z MEMBER

@fujiisoup - This is looking pretty good. I'll let @MaximilianR give the final review since he's spent more time here than I have. As for your four points above, I think I'm fine with all of those design decisions.

One minor point though (no change needed)

All the attrs are dropped

I don't think this is true for data_vars that don't have rolling-dim in them.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  211323643
Powered by Datasette · Queries took 0.748ms · About: xarray-datasette