issue_comments: 284226244

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1289#issuecomment-284226244 https://api.github.com/repos/pydata/xarray/issues/1289 284226244 MDEyOklzc3VlQ29tbWVudDI4NDIyNjI0NA== 6815844 2017-03-05T13:00:02Z 2017-03-05T13:02:00Z MEMBER
  • Now DatasetRolling.reduce() keeps its original data_vars order.
  • Dataset.rolling is added to api.rst.

I updated DatasetRolling so that its reduce method relies mostly on DataArrayRolling.reduce rather than window.reduce. This change makes not only the reduced-Dataset keep its original order of data_var, but also makes the code much cleaner. I moved many methods from Rolling to DataArrayRolling because DatasetRolling does not use them anymore.

However, I guess Rolling class is originally designed to be used also for Dataset, as discussed in #859. If someone has any requests, I will reconsider the class structure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   211323643