home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 284217037

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1289#issuecomment-284217037 https://api.github.com/repos/pydata/xarray/issues/1289 284217037 MDEyOklzc3VlQ29tbWVudDI4NDIxNzAzNw== 6815844 2017-03-05T09:48:55Z 2017-03-05T09:48:55Z MEMBER

@shoyer Thanks for the review.

I didn't notice Dataset keeps the order of data_vars. I think I should change the direction, because the data_var's order is destroyed after the final merge call.

Maybe DatasetRolling should not be a child of Rolling, but an independent class that has an OrderedDict of Rolling for each data_var to preserve the variable order.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  211323643
Powered by Datasette · Queries took 0.596ms · About: xarray-datasette