home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 283666553

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1291#issuecomment-283666553 https://api.github.com/repos/pydata/xarray/issues/1291 283666553 MDEyOklzc3VlQ29tbWVudDI4MzY2NjU1Mw== 10050469 2017-03-02T14:25:07Z 2017-03-02T14:25:07Z MEMBER

Seems pretty safe to me, thanks! Could you add some tests, too? (at least for proper code coverage)

A good place to put a test would be here: https://github.com/pydata/xarray/blob/master/xarray/tests/test_plot.py#L638

(I suspect your PR brakes these tests, btw)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  211391408
Powered by Datasette · Queries took 1.209ms · About: xarray-datasette