home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 276538303

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/60#issuecomment-276538303 https://api.github.com/repos/pydata/xarray/issues/60 276538303 MDEyOklzc3VlQ29tbWVudDI3NjUzODMwMw== 1217238 2017-02-01T00:30:32Z 2017-02-01T00:30:32Z MEMBER

Yes, that looks pretty reasonable. Two minor concerns: - obj.fillna(-np.inf) converts all dtypes to float. It would be better to stick to obj.fillna(0), though integers can't have NaNs anyways. - I'm pretty sure .fillna(np.nan) is a no-op, filling in NaNs with NaN.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  29136905
Powered by Datasette · Queries took 0.626ms · About: xarray-datasette