home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 274439260

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1222#issuecomment-274439260 https://api.github.com/repos/pydata/xarray/issues/1222 274439260 MDEyOklzc3VlQ29tbWVudDI3NDQzOTI2MA== 10050469 2017-01-23T09:34:43Z 2017-01-23T09:34:43Z MEMBER

My strongest preference is that all names have the same form, e.g., assert_X_equal, assert_X_identical and assert_X_allclose where X is the same token.

Agreed. Currently X is nothing, but I'm happy with either option you suggest. Also, my docstrings might need a short review as well to make sure I got them right.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  202124581
Powered by Datasette · Queries took 0.766ms · About: xarray-datasette