home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 274374525

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1084#issuecomment-274374525 https://api.github.com/repos/pydata/xarray/issues/1084 274374525 MDEyOklzc3VlQ29tbWVudDI3NDM3NDUyNQ== 1217238 2017-01-23T00:51:39Z 2017-01-23T00:51:39Z MEMBER

As for the implementation in your gist, it looks pretty solid to me. One possible concern is that we are overwriting _maybe_cast_slice_bound, which is a private method, and it's not entirely clear what parts of pandas Index API (if any) are designed for subclassing. But this is certainly unlikely to break anytime soon (prior to pandas 2.0, which we will see coming a long ways off).

It might also be worth testing this index in a pandas DataFrame/Series. I don't expect things to work 100% but it might be enough to be useful.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  187591179
Powered by Datasette · Queries took 0.928ms · About: xarray-datasette