issue_comments: 274230635

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1222#issuecomment-274230635 https://api.github.com/repos/pydata/xarray/issues/1222 274230635 MDEyOklzc3VlQ29tbWVudDI3NDIzMDYzNQ== 1217238 2017-01-21T03:28:13Z 2017-01-21T03:28:13Z MEMBER

What do people think about the names of the functions? Numpy includes array as in assert_array_equal

I would lean towards assert_equal. Maybe assert_data_equal or assert_object_equal? I guess even assert_xarray_equal could be OK, though the name feels redundant to me with the namespace. I would prefer assert_data_equal, except that could be confused to only apply to the .data attribute.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   202124581