home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 272323006

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1198#issuecomment-272323006 https://api.github.com/repos/pydata/xarray/issues/1198 272323006 MDEyOklzc3VlQ29tbWVudDI3MjMyMzAwNg== 4295853 2017-01-13T00:03:24Z 2017-01-13T00:03:24Z CONTRIBUTOR

Thanks @shoyer. This makes sense. I think the path forward on the next round of edits should include making sure existing tests using open_mfdataset use both options to autoclose. If we do this we could future-proof ourselves against loss due to accidental breaking of this new functionality and avoid potentially contaminating existing workflows via performance concerns.

Documentation is also obviously required.

FYI as a heads up, I probably won't be able to get to this mid-week at the earliest but it appears we are close to a viable solution.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  199900056
Powered by Datasette · Queries took 160.828ms · About: xarray-datasette